fixUniversalLink #398
Merged
fixUniversalLink #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* introduce appLinkUrl in PayPalWebVaultRequest and PayPalWebCheckoutRequest
* deprecate vault function without app switch feature
* deprecate vault function without app switch feature * introduces startAsync, vaultAsync functions to provide suspend support
* fix unit tests * update unit tests
sshropshire
reviewed
Nov 6, 2025
sshropshire
reviewed
Nov 6, 2025
sshropshire
reviewed
Nov 6, 2025
sshropshire
reviewed
Nov 6, 2025
Demo/src/main/java/com/paypal/android/ui/paypalweb/PayPalCheckoutViewModel.kt
Show resolved
Hide resolved
sshropshire
reviewed
Nov 6, 2025
PayPalWebPayments/src/main/java/com/paypal/android/paypalwebpayments/PayPalWebCheckoutClient.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Nov 6, 2025
PayPalWebPayments/src/main/java/com/paypal/android/paypalwebpayments/PayPalWebCheckoutClient.kt
Show resolved
Hide resolved
* remove unwanted logs * removed unnecessary code
* add fallbackUrlScheme to PayPalWebVaultRequest
* update public API
sshropshire
reviewed
Nov 24, 2025
PayPalWebPayments/src/main/java/com/paypal/android/paypalwebpayments/PayPalWebCheckoutClient.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Nov 24, 2025
PayPalWebPayments/src/main/java/com/paypal/android/paypalwebpayments/PayPalWebVaultRequest.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Nov 24, 2025
PayPalWebPayments/src/main/java/com/paypal/android/paypalwebpayments/PayPalWebVaultRequest.kt
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Nov 24, 2025
Demo/src/main/java/com/paypal/android/ui/paypalwebvault/PayPalVaultViewModel.kt
Outdated
Show resolved
Hide resolved
sshropshire
approved these changes
Nov 24, 2025
* use appUrl and fallback app url scheme in demo app
kgangineni
force-pushed
the
fixUniversalLink
branch
from
5d6707a to
acc3b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
startAsync,vaultAsyncsuspend functionsappLinkUrlinPayPalWebVaultRequestandPayPalWebCheckoutRequestto support universal linksurlSchemeinPayPalWebCheckoutClientappLinkUrlis not null then used for navigation, if not usedurlScheme, if both are null then result will be failure, this logic is handled in Browser SwitchChecklist
Authors